Update MoonBit extension to v0.1.7#6649
Conversation
MrSubidubi
changed the title
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
You lost some capabilites such as the auto-language server install as well as the workspace configuration and the renaming of the language server ID is a somewhat breaking change. Were both intentional?
|
Good catch, thanks! Neither was intended as a regression. When syncing the repositories I treated my implementation as the source of truth and focused primarily on bringing the extension up to date with the MoonBit 0.10 grammar, validation pipeline, and CI. In doing so I unintentionally dropped those existing capabilities. I’ll restore the auto-install behavior, preserve the existing language server ID for backwards compatibility, and keep the remaining improvements from the synchronization. |
Metalymph
changed the title
|
Good catch — thanks. Those regressions were not intentional. I’ve patched the extension and updated this PR to v0.1.7. Changes made:
The registry PR now points to quirk-lab/zed-moonbit tag v0.1.7. Validation passed:
|
2 participants
Summary
This updates the existing MoonBit extension to
v0.1.7.Since the previous discussion, I have joined the existing
quirk-lab/zed-moonbitrepository as a maintainer, and the MoonBit 0.10 support has been merged there. This keeps MoonBit support consolidated into a single maintained extension.Changes
v0.1.7quirk-lab/zed-moonbitmoonbitlanguage server ID for compatibility with existing Zed settingsThis PR updates the existing extension only; it does not introduce a second MoonBit extension.
Validation
git diff --check.gitmodulespoints tohttps://github.com/quirk-lab/zed-moonbit.git[moonbit].version = "0.1.7"inextensions.tomlextensions/moonbitpoints to tagv0.1.7commit4d2e9cb40c16adbfa4c16f6c5fabc1c975e3419aextensions.tomlandextensions/moonbitquirk-lab/zed-moonbit:cargo fmt --check,cargo check,just validate-queries,just test-syntaxpnpm buildcould not complete locally due to an unrelated existing TypeScript environment issue:TS2688: Cannot find type definition file for 'minimatch'. The MoonBit update diff is limited to the extension version and submodule pointer.